fix: prevent plugin crash from unsafe type assertions in Read functions#864
Merged
fbreckle merged 1 commit intoe-breuninger:masterfrom Apr 8, 2026
Merged
Conversation
…in crash Fixes e-breuninger#806. Unchecked type assertions in 13 resource Read functions would panic if the API returned a non-HTTP error (e.g. network timeout, context cancellation), crashing the Terraform plugin process. Replaced with the safe two-value assertion form, consistent with the rest of the codebase.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Read functions used unchecked Go type assertions that panic when the API returns a non-HTTP error (network timeout, DNS failure, etc.), crashing the Terraform plugin.
Affected Resources
netbox_cable,netbox_config_context,netbox_device_bay,netbox_device_front_port,netbox_device_module_bay,netbox_device_power_feed,netbox_device_power_outlet,netbox_device_power_port,netbox_device_rear_port,netbox_inventory_item,netbox_inventory_item_role,netbox_module,netbox_module_type,netbox_power_panelFixes: #806